-
Notifications
You must be signed in to change notification settings - Fork 1.3k
fix(vite): the @qwik-handlers aren't properly handled in dev mode for library projects #7608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: build/v2
Are you sure you want to change the base?
Conversation
commit: |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
🦋 Changeset detectedLatest commit: 96ed68f The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
} else { | ||
return plugin(); | ||
} | ||
return plugin; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you look in the commit history to see why this was added?
Are you sure that the function gets executed? Can you add a console.log() inside it to check?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plugin this function ? @wmertens
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it directly returns a function, that function will be invoked by Vite at the very end
Update the version bump in the changeset file from 'major' to 'patch' to reflect the correct severity of the fix for @qwik-handlers in dev mode for library projects.
What is it?
Description
an http source request will be blocked by middleware in Qwikcore when project is the library mode.
this is because library mode's
plugin
function inconfigureServer
will be executed immediately, in contrast, in a normal project that has a router Vite plugin will be deferred.#7600
Checklist
pnpm change